Skip to content

Proto: add Sc_rollup destination

Mehdi Bouaziz requested to merge mehdi@sc_rollup_destination into master

Context

Adds Sc_rollup to the destinations, which is used for Michelson addresses.

Done:

  • VIEW returns None, like on Tx_rollup
  • parsing sc_rollup addresses depends on the sc_rollup_enable flag

To be changed in later MRs:

Based on !5326 (merged), !5310 (merged), !5317 (merged).

Closes #2798 (closed)

Manually testing the MR

  • ./tezos-client -M mockup typecheck data '"scr1HLXM32GacPNDrhHDLAssZG88eWqCUbyLF"' against type address
Ill typed data: 1: "scr1HLXM32GacPNDrhHDLAssZG88eWqCUbyLF"
is not an expression of type address
At line 1 characters 0 to 39, value "scr1HLXM32GacPNDrhHDLAssZG88eWqCUbyLF"
is invalid for type address.
{ "id": "proto.alpha.michelson_v1.sc_rollup_disabled",
  "description":
    "Cannot use smart-contract rollup features as they are disabled.",
  "data": { "location": 0 } }
Fatal error:
  ill-typed data
  • turn sc_rollup_enable to true in test-parameters.json
    • ./tezos-client -M mockup create mockup --protocol-constants test-parameters.json
    • ./tezos-client -M mockup typecheck data '"scr1HLXM32GacPNDrhHDLAssZG88eWqCUbyLF"' against type address
Well typed
Gas remaining: 1039996.540 units remaining

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Mehdi Bouaziz

Merge request reports