Skip to content

Proto, storage: introduce "add" function for Carbonated_data_set_storage

David Turner requested to merge add-op into master

Context

Add a "add" method to Carbonated_data_set_storage. Data_set_storage already has this, and it's inconvenient to have to check mem before calling init.

I haven't added any testing because !4276 (merged) has the test framework and isn't merged yet. But I manually tested it, and it works.

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, the Development Version section of CHANGES.md for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports