Skip to content

Proto: remove autostaking dead code

Diane Gallois-Wong requested to merge diane@remove_autostaking_dead_code into master

What

Remove the autostaking code, which is no longer used in mainnet since AI has been activated in June 2024.

Why

  • Remove dead code and control flow that makes the protocol needlessly complex.
  • Force all tests to use post-AI staking instead of relying on a feature that has been absent from mainnet for months.

How

  • Remove autostaking functions and control flow from alpha protocol.
  • Remove autostaking feature flag from alpha protocol.
  • Remove all tests that explicitly test autostaking (or no longer run them on alpha).
  • Remove tests on set_deposits_limit on alpha, and test instead that it always fails.
  • Remove explicit autostaking activation from alpha tests.
  • Add manual staking to some tests that used to rely on autostaking for new accounts to be able to have rights.
    • For tezt tests, depending on what was easier to do, either do this change only when running the test on alpha, or do it for P and Q too but explicitly activate AI so that autostaking is off and manual staking is permitted in P and Q as well.

Manually testing the MR

CI

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • [N/A] Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Diane Gallois-Wong

Merge request reports

Loading