Snoop: default benchmark parameters (nsamples, bench_num) are not coded
I believe these options are not in the code except the global default in bin_snoop/. It is not appropriate for the timer latency and intercept cases where bench-num should be 1. Non-experts have no idea what they should be.
The auto-build #4075 (closed) needs the default recommended options for the benchmarks, which performs multiple benches automatically as necessary.
-
Global defaults of bench_num and samples. (We already have them) -
Benchmark-wise defaults of them. Most of all the cases they are equal to the global defaults. - Do not extend
default_config
ofBenchmark.S
. Its implementation is hidden and different between benchmarks. Define a new field for bench_num and nsamples. - Maybe we want more info like
Measure.options
.
- Do not extend
-
Benchmark printing should print them. -
Specify the current recommended bench_num and samples for each benchmark -
octez-snoop benchmark
's --bench-num and --nsamples options can override them. If they are not specified the benchmark's default values should be used.
Edited by Jun Furuse