Follow-up from "Draft: Tenderbake"
The following discussions from !2664 (closed) should be addressed:
-
@hai-nguyen-van started a discussion: (+1 comment) So, if I clearly understand, at this point I wish to inject a fresh proposal. This candidate block of - let's say - level 10, will have to include endorsements and preendorsements for level 9 (gathered from the previous phases). Why don't we also add here the preendorsements (as it is done in case
Some
)? -
@hai-nguyen-van started a discussion: (+3 comments) I can't seem to find where in the code this field
state.instance_context.endorsementQC
is being filled with operations? Is it inEvent_loop
? -
@hai-nguyen-van started a discussion: (+1 comment) I can see that this function is updating the field
endorsements
oftype round_context
. At which point, do we make link with the fieldendorsementQC
oftype instance_context
? -
@hai-nguyen-van started a discussion: (+2 comments) As I understand, the function
timestamp_of_round
returns the timestamp as whichround
starts using the constant parametersround_durations
, the timestamp of the predecessor roundpredecessor_timestamp
and the predecessor round itselfpredecessor_round
.This would mean that
predecessor_round
andpredecessor_timestamp
are the round/timestamp at the predecessor level. If I increase the rounds for the current levell
and call this function, the argumentspredecessor_timestamp
andpredecessor_round
should remain unchanged because they target levell - 1
. Is this semantics correct?