Code smells
Upon browsing through the code I found some weird stuff.
-
in cppapi/server/dserver.cpp line 531 in method ~DServer, there is a break statement that seems weird
-
in cppapi/client/devapi_pipe.cpp line 1061, in method DevicePipeBlob & DevicePipeBlob::operator<<(DevString &datum) we use the index insert_ctr when I would expect insert_ind
-
in cppapi/server/w_attribute.cpp line 1194 in method check_written_value for enum we can throw an error if the enum is out of bound, but after the value has been set to short_val…
Edited by Damien Lacoste