Follow-up from "[PRE !501] locales management implementation"
The following discussions from !500 (merged) should be addressed:
-
@V.Lacroix started a discussion: (+1 comment) I see three fixed known bugs in test report:
ok 247 001 CreateMonitoredItems: Script specifies an invalid IndexRange outside the bounds of the array item. - FIXED KNOWN BUG ok 310 005 DoS attack #2; consume SecureChannels, but CreateSessions in some. - FIXED KNOWN BUG ok 317 005 DoS attack #2; consume SecureChannels, but CreateSessions in some. - FIXED KNOWN BUG
Two of them may correspond to flaky tests but what about the third one ?
-
@V.Lacroix started a discussion: why declare the booleans inside the loop and integers outside the loop ?
-
@V.Lacroix started a discussion: you can authorize yourself an early return.
-
@V.Lacroix started a discussion: this -1000 is not explained in the docstring.
-
@V.Lacroix started a discussion: early return ?
-
@V.Lacroix started a discussion: why ?
-
@V.Lacroix started a discussion: this return is not so early ;-)
-
@V.Lacroix started a discussion: I suggest adding some parenthesis (even if they are superfluous
-
@V.Lacroix started a discussion: it is not the opposite ? If
includesCountryRegion
is true then you consider '-' as a separator ? -
@V.Lacroix started a discussion: early return ?
-
@V.Lacroix started a discussion: hum. Don't you perform twice the same comparison ?
-
@V.Lacroix started a discussion: constants shall be put at the left side of comparison (cf coding rules)
-
@V.Lacroix started a discussion: parenthesis ?
-
@V.Lacroix started a discussion: don't we need to free
localeIds
here ? -
@V.Lacroix started a discussion: after use ?
-
@V.Lacroix started a discussion: to modify it
-
@V.Lacroix started a discussion: not
status = SOPC_STATUS_INVALID_PARAMETERS
to clear with next code snippet ? -
@V.Lacroix started a discussion: This function can be greatly simplified with early returns ?
-
@V.Lacroix started a discussion: do you mean modifiable ?
-
@V.Lacroix started a discussion: constants shall be to the left side of comparison