Follow-up from "Add a client-side demonstration subscription library"
The following discussions from !156 (merged) should be addressed:
-
@abustany started a discussion: (+2 comments) this symbol (and others) in this file are out of the
SOPC_
prefix, we probably want to avoid that? -
@abustany started a discussion: (+1 comment) Can you use
SOPC_DateTime_ToTimeT
here ? -
@abustany started a discussion: well, it's shallow copied, so if you free not only the struct but the strings in there, bad things will happen :)
-
@abustany started a discussion: no need for null checks before calling free
-
@abustany started a discussion: in theory that malloc could fail too... Or else we just make a wrapper in that client tool that does abort when malloc fails, and are done with it.
-
@abustany started a discussion: (+1 comment) errrr NodeId is not POD at all ?
-
@abustany started a discussion: pNid should be const, or else shouldn't be freed in state_machine.c when calling this function I guess?
-
@abustany started a discussion: this null check is not needed
-
@abustany started a discussion: this null check is not needed
-
@abustany started a discussion: if that method fails, are we supposed to free pReq as well ?
-
@abustany started a discussion: hmm we invoke the callback even if status is not ok ?
-
@brameret started a discussion: Make this function static.