Rework server_validate_session_service_resp
This operation is implemented in module session_core
and called from service_mgr_i
in two places:
-
server_receive_session_service_req
for a synchronous response, -
server_send_publish_response
for an asynchronous response.
After discussion with Vincent Monfort it appears that:
- the first call is useless: we have already checked the session and its associated channel, and these cannot have changed during the treatment. So there is no reason to validate them again.
- the second call is useful (the session or channel may have changed since the processing of the request), but it should never return the
e_sc_bad_secure_channel_id_invalid
error code which is meaningless (the channel is not an input parameter, but a result of the operation).