velero: avoid producing a broken BackupStorageLocation
Today, if enabled, our velero unit will always create a velero-bsl BackupStorageLocation, but this resource will only reconcile correctly if valid S3 settings were provided in backup.store.s3.
If there is no backup.store.s3 valid configuration the associated HelmRelease controller health-check will fail:
Warning InstallFailed Helm install failed for release velero/velero with chart velero@12.0.0: timeout waiting for: [BackupStorageLocation/velero/velero-bsl status: 'InProgress']To solve this problem, we should:
- move the
backupStorageLocationresource definition somewhere under_internal - include it in the values conditionally, using
set-ony-if, only if all the needed S3 parameters are provided underbackup.store.s3