leverage SylvaUnitsRelease additional reconciliation to clear one-shot unit Kustomizations

We have units st wit one_shot: true, which has the effect of having them be automatically disabled on the next reconciliation (their Kustomization will then be deleted).

There is however something imperfect in how this is tested.

Take for instance the following scenario:

  • deploy sylva 1.6
  • upgrade to sylva 1.7
    • some transitional units having one_shot: true are run
  • (these steps are tested in CI)
  • on the next apply.sh, the Kustomization for these one_shot: true units will be deleted, but our CI does not test this

Not testing what happens on the deletion of these Kustomizations is not good, because if we get something wrong, this deletion may have problematic side-effects.

Proposal: leverage the framework that we have for "2-step" upgrades, which lets' sylva-units signal to the SylvaUnitsRelease operator that an additional reconciliation is needed.

In practice, this would consist in having sylva-units.sylva-project.org/additional-reconciliation-requested be set (https://gitlab.com/sylva-projects/sylva-core/-/blob/755f919f3248a3cbd44d4d8968bea534ab43805a/charts/sylva-units/templates/sylva-units-values.yaml#L105) whenever there exists a one-shot unit for which the Kustomization was produced.