need to enable drift correction for calico HR
It is important to enable drift correction on calico HelmRelease, in particular because the behavior of HelmRelease controller is better in that case for resources which are adopted by the HelmRelease at the moment where there is a handover from RKE2 HelmChart to the FluxCD HelmRelease.
For now we haven't yet enabled drift correction on calico because it was found to be causing kubeadm deployments to fail.
While working on !2445 (merged), it was noticed that when we are enabling drift detection and correction for calico HR, the deployment is getting failed as the HR's are getting drifted from the desired state.
Below are the logs of helm-controller with the JSON patch summary logged in the helm-controller with the value the helm controller tends to apply and the path at which it is applying the patch:
{"level":"debug","ts":"2024-10-26T23:26:33.608Z","msg":"resource modified","controller":"helmrelease","controllerGroup":"helm.toolkit.fluxcd.io","controllerKind":"HelmRelease","HelmRelease":{"name":"calico","namespace":"sylva-system"},"namespace":"sylva-system","name":"calico","reconcileID":"f3846d07-09cd-4cab-926c-c3659dd64d3f","resource":"Installation/default","patch":[{"value":{"cidr":"100.72.0.0/16","disableBGPExport":false,"encapsulation":"VXLAN","natOutgoing":"Enabled"},"op":"replace","path":"/spec/calicoNetwork/ipPools/0"}]}
{"level":"debug","ts":"2024-10-26T23:26:33.609Z","logger":"events","msg":"Cluster state of release sylva-system/calico.v2 has drifted from the desired state:\nInstallation/default changed (0 additions, 1 changes, 0 removals)","type":"Warning","object":{"kind":"HelmRelease","namespace":"sylva-system","name":"calico","uid":"8d748db4-7209-45aa-9238-e9c409848c72","apiVersion":"helm.toolkit.fluxcd.io/v2beta2","resourceVersion":"52764"},"reason":"DriftDetected"}