simplify apply.sh/bootstrap.sh/apply-w-c.sh validation stage
The validation/preview step in apply.sh/bootstrap.sh/apply-w-c.sh has an history, leading to something which can be simplified.
Historically, we didn't had the capabilities that sylvactl has today, or that it will get soon (in particular sylva-projects/sylva-elements/sylvactl!85 (merged)), and this step was used to:
- wait for a "preview" HelmRelease for some time
- display useful status.conditions if it didn't come up quickly, to allow displaying schema validation or Helm template failure quickly enough
Today, given the new abilities of sylvactl, using it directly on the final HelmRelease would already achieve most of that.
The "to allow displaying schema validation or Helm template failure quickly enough" will be easily achieved once sylva-projects/sylva-elements/sylvactl!85 (merged) is implemented.
So, once sylva-projects/sylva-elements/sylvactl!85 (merged) is implemented I think we can:
- remove the validation/preview step from
apply.shandapply-workload-cluster.sh; thesylvactl --watchthat we have on the real final HelmRelease will give proper user feedback, quickly enough - for
bootstrap.sh, remove the validation/preview which is done for bootstrap values (same reason as above), but keep the one for management cluster values