Unable to override feature gate argument in capi deployment.
Description
After the major release (1.5 -> 1.6) change in core-components. The position of feature gate arguments is moved up by 1.
https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.6.3/core-components.yaml
Earlier it was
spec:
containers:
- args:
- --leader-elect
- --metrics-bind-addr=localhost:8080
- --feature-gates=MachinePool=${EXP_MACHINE_POOL:=false},ClusterResourceSet=${EXP_CLUSTER_RESOURCE_SET:=false},ClusterTopology=${CLUSTER_TOPOLOGY:=false},RuntimeSDK=${EXP_RUNTIME_SDK:=false},MachineSetPreflightChecks=${EXP_MACHINE_SET_PREFLIGHT_CHECKS:=false}
command:
- /manager
Now it is
spec:
containers:
- args:
- --leader-elect
- --diagnostics-address=${CAPI_DIAGNOSTICS_ADDRESS:=:8443}
- --insecure-diagnostics=${CAPI_INSECURE_DIAGNOSTICS:=false}
- --feature-gates=MachinePool=${EXP_MACHINE_POOL:=false},ClusterResourceSet=${EXP_CLUSTER_RESOURCE_SET:=false},ClusterTopology=${CLUSTER_TOPOLOGY:=false},RuntimeSDK=${EXP_RUNTIME_SDK:=false},MachineSetPreflightChecks=${EXP_MACHINE_SET_PREFLIGHT_CHECKS:=false}
Expected Output
Currently capi deployment looks like
spec:
containers:
- args:
- --leader-elect
- --diagnostics-address=:8443
- --feature-gates=MachinePool=false,ClusterResourceSet=false,ClusterTopology=false
- --feature-gates=MachinePool=false,ClusterResourceSet=false,ClusterTopology=false,RuntimeSDK=false,MachineSetPreflightChecks=false
command:
- /manager
However, It should look like this
spec:
containers:
- args:
- --leader-elect
- --diagnostics-address=:8443
- --insecure-diagnostics=false
- --feature-gates=MachinePool=false,ClusterResourceSet=false,ClusterTopology=false
command:
- /manager
Edited by Jagrati Shivhare