Skip to content

Grouping - outstanding issues

In !549 (merged) grouping was introduced. It was identified that things can be improved, but better to get it in and try it out.

These are the unchecked items from that MR, feel free to correct/add more:

  • remove redundant API functions from tree, name cleanup !581 (merged)
  • remove selection API? (use iter_mut etc. from the app) !581 (merged)
  • consistently replace old index types !563 (merged)
  • general integration cleanup, consistent variable names, etc. !563 (merged)
  • make struct for extra iterator and add last to save on some scans !565 (closed)
  • improve dragging UX !561 (merged)
  • selection across whole line !567 (closed)
  • allow window to become wider then content !567 (closed)
  • add a line to further convey indentation under fold-icon?
  • have a consistent idea what it means if e.g. a context action is made on an item that is not selected (e.g. color change via context menu on unselected item while some others are focused and/or selected) - and should this be dependent on modifier keys?
  • spade-decoded signals in groups are...suboptiomal :-( A possible way forward would be to drop all the special handling for variables and insert them like all other signals into the signal tree. (more work for insert/delete/etc. though). If we want to we could prevent reorder/move/etc. of variables to keep the feel the same
  • consider making focused_item a reference since we need to convert so often?
  • if spade-decoded item is inserted twice, egui has duplicate IDs
  • think some more about right alignment

I'll also add a few more:

  • Make it easier to create groups with the mouse
  • #352
  • Add a mechanism to select a "translator" for the group level, i.e., display a waveform and text based on the signals included in the group.
Edited by Andreas Wallner