WebService::ILS::OverDrive::Patron does not pass perl -cw
Hello Srdjan,
$ perl -cw /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm
Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365.
Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573.
Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643.
/usr/share/perl5/WebService/ILS/OverDrive/Patron.pm syntax OK
573 die ($data->{message} || $data->{errorCode})."\n";
I have to admit I don't really understand why it's failing.
I guess perl warns because it expects to see die and "or" instead of "||", but here it's not a die ... or!
Anyway, the warnings are removed with
573 my $error = ($data->{message} || $data->{errorCode})."\n";
574 die $error;
Are you still maintaining this module? Would you accept a merge request?