Skip to content

Pre-processed files should be removed

Created by: delcypher

The pre-processed files are causing lots of problems

  • It's really easy to make an architecture mistake when pre-processing a source file (i.e. what I reported on in my first e-mail in this thread). See #121
  • It is a huge waste of space. We are effectively doubling (at least) the size of the repository by having these pre-processed files under source control
  • It doubles the maintenance effort when fixing benchmarks files because both the *.i and corresponding *.c files need to be fixed by hand! I dare not regenerate the *.i files automatically because I have no way of knowing what build environment the original creator of the benchmark used (this is why we need to define a "canonical" build environment). It also makes code reviews harder
  • The line pragmas in the *.i files make debugging benchmarks extremely difficult. When I found compilation issues I had to remove all the line pragmas to get a readable error message from the compiler.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information