Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • solarus solarus
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 222
    • Issues 222
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Solarus Games
  • solarussolarus
  • Issues
  • #1116

Closed
Open
Created Nov 28, 2017 by Diarandor@DiarandorDeveloper

Request: more consistency for angle units

Some functions like "sol.main.get_angle(x1, y1, x2, y2)" work in radians. However, the circle movements work in degrees (initial angle, angle speed, etc). This is too confusing. All of these functions should use the same angle unit, and I personally prefer radians, although other people (like kids) may prefer degrees.

The best option could probably be to add another parameter (an optional parameter if you prefer) on each of these functions to indicate if we are using degrees or radians as angle unit. That is, if "unit" is one of the strings in the list {"degrees", "radians"}, we would write:

sol.main.get_angle(x1, y1, x2, y2, unit)
circle_movement:get_angle_speed(unit)
circle_movement:set_angle_speed(angle_speed, unit)

etc. And the same for all functions in the Lua API that use angles or angle speeds.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking