Commit aadabb88 authored by Nathaniel Suchy's avatar Nathaniel Suchy 😄

Remove some things, refactoring, etc

parent c1e163b1
Pipeline #55786731 failed with stages
in 11 minutes and 45 seconds
# How To Contribute
First thank you for taking the time to contribute to HacksDB, we really appreciate all of the community support.
## Search for an Issue
The easiest way for any community member to contribute (with or without software engineering knowledge) is to find an issue, and create a GitLab Issue if it's not already being tracked.
## What types of merge requests are we unable to accept
A lot of work goes into reviewing each merge request. At least two members of our team will review a proposed change before it's accepted. We do not want to see the overall code quality drop so we take our time in the review and quality assurance process. Because of this we're unable to accept the following types of merge requests and will have close merge requests that fall into these categories:
* Merge requests that do not reference a GitLab Issue. GitLab Issues serve as a discussion board for our team and community stakeholders to discuss a proposed feature, bug, or other changes.
* Merge requests that do not add a feature or fix a bug.
* Merge requests that only add comments.
* Merge requests that only fix typos in code comments.
* Merge requests that only consist of small code refactors.
There is a monthly User Feedback & Suggested Changes merge for unacceptable merge requests. The changes are based on feedback in the [March 2019 - User Feedback & Suggested Changes](https://gitlab.com/sm64hacks/webapp/issues/1) Issue and implemented by a team member. The more details you provide (codeblocks are great) in your comments, the better the merge will be at the end of the month.
\ No newline at end of file
# Record Types
These are the IDs of Record Types which require a formal request processed before the data may be accessed.
1) User
2) Report
## One-liners
These are a few "one-liners" site security engineers can use to fetch information from data requests.
**IP Address of a Report**
```
x = 1
Report.find_by_id(DataRequest.find_by_id(x).record_id).ipaddress
```
\ No newline at end of file
......@@ -3,9 +3,9 @@ class PagesController < ApplicationController
@page_title = "Home"
end
def help
@page_title = "Help"
end
# def help
# @page_title = "Help"
# end
def error
@page_title = "Error"
......
<div class="jumbotron jumbotron-fluid">
<div class="container">
<h1 class="display-4">Reporting Hack <%= @hack.name %></h1>
<p>Use this form to flag a hack for removal from the database. Please provide an explaination requiring the removal of the reported hack. If you are requesting removal for legal reasons or on copyright grounds please send an email to admin@sm64hacks.com. We cannot process legal & copyright requests through this form! Due to the volume of reports we cannot provide a personal response to reports made through this form and we do not collect information about who submitted a report.</p>
<h1 class="display-4">Requesting Admin Review for <%= @hack.name %></h1>
<p>Use this form to flag a hack for admin review. Please provide an explaination requiring the review of the reported hack. If you are reporting a broken version link <u><strong>please include the version name</strong></u>!
<br><br>
If you are requesting removal for legal reasons or on copyright grounds please send an email to admin@sm64hacks.com. We cannot process legal & copyright requests through this form! Due to the volume of reports we cannot provide a personal response to reports made through this form however we do read each report.</p>
<hr />
<%= form_for(:report, url: "/hack/report/#{@hack.id}") do |f| %>
<div class="form-group">
......@@ -9,7 +13,7 @@
<%= f.text_area :reason, :placeholder => "Reason", required: true, class: "form-control" %>
</div>
<%= f.hidden_field :hack_id, value: @hack.id %>
<%= f.submit "Submit Report", class: "btn btn-primary" %>
<%= f.submit "Request Admin Review", class: "btn btn-primary" %>
<% end %>
</div>
</div>
<div class="alert alert-info" role="alert" id="everdrive-alert">
Everdrive Compatibility information is currently hidden as it's misleading in its current form. We hope to add a new compatibility system soon.
</div>
<div class="jumbotron jumbotron-fluid">
<div class="container">
<div class="alert alert-info" role="alert" id="everdrive-alert">
Everdrive Compatibility information is currently hidden as it's misleading in its current form. We hope to add a new compatibility system soon.
</div>
<h1 class="display-4 text-center"><%= @hack.name %></h1>
<p class="lead text-center"><%= @hack.description %></p>
<% if @hack.youtube_url %>
......
......@@ -35,9 +35,9 @@
<!-- <li class="nav-item">
<a class="nav-link" href="/search">Search Hacks</a>
</li> -->
<li class="nav-item">
<!-- <li class="nav-item">
<a class="nav-link" href="/help">Help</a>
</li>
</li> -->
<% if current_user %>
<% if current_user.admin %>
<li class="nav-item">
......
Rails.application.routes.draw do
# Page Routes
get '/' => 'pages#index'
get '/help' => 'pages#help'
get '/test' => 'pages#test'
# get '/help' => 'pages#help'
# get '/test' => 'pages#test'
get '/error' => 'pages#error'
get '/requested/:id' => 'pages#requested'
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment