Bug in hiding impact-less facets
With #76 (closed) impact-less facets are to be hidden in the search result page. However, the ticket also stated:
In the following case:
Sex
- Total (5)
- Women (2)
- Men (2)
We could only hide the "Total" value but it might be confusing, because the user might wonder if "Total" was actually not available and could abandon the search... Therefore, in this case it might be better to keep the filter completely.
It appears that this rule was broken by the wrong ticket #896 (closed), which needs to be reverted. Also the related wrong documentation made in #1102 (closed) needs to be reverted.
In OECD prod, on this page, all OECD countries are wrongly missing in the "Reference Area" facet because all dataflows have data for OECD countries.
Remember: Only complete facets are to be hidden if ALL of their items have the count equal to the search results. If only some but not ALL items have such a count then none of the items are to be hidden individually. Instead the whole facet with ALL its items is to be displayed.
It can be reproduced in QA with the "Country" facet: https://de-qa.siscc.org/?pg=0&fc=Country&bp=true&tm=Emissions%20of%20air%20pollutants,
and in Staging with the "Reference Area" facet: https://de-demo.siscc.org/?pg=0&fc=Reference%20area&bp=true&tm=UoM
This implementation should also solve this case where the Topic facet misses Economy
: