remove saga
in this ticket, structure, data and hcl sagas are the targets.
tech flow when in selectHandler
(RQ selector):
- remove redux selector
- replace selector by RQ hook in components
- remove from redux state (update reducer, update action payload)
- handle selectors using removed selector (https://flufd.github.io/reselect-with-multiple-parameters/):
- selector gain arg
- handle selector(s) with arg
tests:
- external: qa localhost
- HCL qa qa localhost
- log mgmt (pushLog stuff)
- error mgmt (hcl)
- microdata
- usecase flow:
- home page, select something that skip search results page (search for single valued facet value)
- if there is no layout nor default selection (applied filters), search for another dataflow
- go back to home and reselect the same facet
- the dataflow should be displayed identically, without any new request
changelog:
- remove structure.annotations in HANDLE_STRUCTURE payload (not used)
- remove defaultPeriod in HANDLE_STRUCTURE payload (not used)
- structure.title renamed to structure.name (update reducer and/or selector)
- structure.description renamed to structure.dataflowDescription
- structure.actualContentConstraints renamed to structure.contentConstraints
- rework reset flow (reset dataflow, reset sdmx, reset search)
integrated changes:
other actions:
- remove dead code tool
- dead code removal (not all, still risky, only related to saga)
Failed e2e test to fix:
-
src/web/tests/tableLayout.e2e.js -
src/web/tests/table-obs-types.e2e.js -
src/web/tests/default-time.e2e.js -
src/web/tests/accessibility.e2e.js -
src/web/tests/visFilters.e2e.js -
src/web/tests/noTime.e2e.js
Edited by Nicolas Briemant