WIP: Conditional mocking of admin mode in specs based on directory
What does this MR do?
Test run for breaking gitlab-org/gitlab!27405 (closed) in chunks.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as ~security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
mentioned in merge request gitlab-org/gitlab!27405 (closed)
added 236 commits
-
5edc0504...adfd65e5 - 232 commits from branch
master
- 27da8ced - Add cost factor fields to ci runners
- e506176d - Merge branch '210570-add-cost-factors-to-ci-runners' into 'master'
- 9a500984 - Conditional mocking of admin mode in specs based on directory
- d61ed565 - Add missing paths to be allowed for mocking
Toggle commit list-
5edc0504...adfd65e5 - 232 commits from branch
mentioned in issue gitlab-org/gitlab#212434 (closed)
added 184 commits
-
d61ed565...84360544 - 182 commits from branch
master
- 66c954c1 - Conditional mocking of admin mode in specs based on directory
- e9e00473 - Add missing paths to be allowed for mocking
-
d61ed565...84360544 - 182 commits from branch
- Resolved by Diego Louzán
- Resolved by Diego Louzán
@dlouzan I'd be okay with this approach and then removing a directory from the list in each merge request. But let's get some thoughts from the Quality team for this.
@rymai Would you be okay with this kind of approach? The goal is to have all admin specs have a tag
:enable_admin_mode
so they run with elevated privileges. The "admin mode" is currently enabled for all specs, but ideally we'd only have that for the specs requiring it. This is what @dlouzan is working on.For most specs, it's just adding the
:enable_admin_mode
tag to make them pass, but some require more effort. Doing it all at once results in a huge MR that 's hard to review (gitlab-org/gitlab!27405 (closed)). So with this, the work could be split up by folder, do you think that makes sense?
added 206 commits
-
e9e00473...bd187a56 - 204 commits from branch
master
- 8bc18d38 - Conditional mocking of admin mode in specs based on directory
- 87b63a91 - Add missing paths to be allowed for mocking
-
e9e00473...bd187a56 - 204 commits from branch
added 163 commits
-
223bfc1f...1d05a0db - 160 commits from branch
master
- a629ced9 - Conditional mocking of admin mode in specs based on directory
- eb7fbcc8 - Add missing paths to be allowed for mocking
- 000390bd - Add new path for mocking in ee specs
Toggle commit list-
223bfc1f...1d05a0db - 160 commits from branch
added 48 commits
-
000390bd...65b9fb37 - 45 commits from branch
master
- 6d1a5814 - Conditional mocking of admin mode in specs based on directory
- 1ac75cb0 - Add missing paths to be allowed for mocking
- e9286f30 - Add new path for mocking in ee specs
Toggle commit list-
000390bd...65b9fb37 - 45 commits from branch
added 133 commits
-
e9286f30...c5e82147 - 130 commits from branch
master
- f4933525 - Conditional mocking of admin mode in specs based on directory
- 510eab08 - Add missing paths to be allowed for mocking
- 981c37a8 - Add new path for mocking in ee specs
Toggle commit list-
e9286f30...c5e82147 - 130 commits from branch
added 1 commit
- 06e78f6d - Conditional mocking of admin mode in specs based on directory
Moved to gitlab-org/gitlab!28420 (merged)