Draft: fixing infinite loop for heay quarks and some near-infinite loop in AHADIC. ...
Description
Fixing an issue with enforced heavy quark splittings in the IS led to a number of subsequent fixes:
- an issue in Jet_Evolution related to an unwanted interplay of REMNANTS::Remnant_Handler instances for hadron decays vs. scatters has been resolved;
- a near infinite loop due to some programming inaccuracy in AHADIC::Cluster_Splitter has been resolved;
- to understand CS_SHOWER::Sudakov.C I had to refactor some methods into smaller pieces; one of the new methods is "MakeSpectatorLists", in which I ignore now a piece that makes spectators for QED splittings. The rationale is that for b-bbar initial states in DY, I always only took muons as spectators for the IS splitting of the b-quarks, which looks wrong.
Test Plan
I will create a list of semi-simple LO run cards in Examples/RemnantTests with reference yodas from before my changes to check if things have changed - will put the results on my web-page as soon as they're there.
Example Result
see above.
Additional Checklist Items
- [n/a] I have updated documentation as needed
- [will have to go to master] I considered if this should be cherry-picked/ported somewhere else (rel-2-x or master), and if yes, opened a corresponding issue or MR