Multi backup support and other improvements to the monitoring script

Antoine Beauprérequested to merge
multi-backup into master

I have done basically a rewrite of the backups nagios monitoring script.

This merge request resolves the following issues:

  • refactor the code to be more modular and grouped by functions
  • support multiple backups per host
  • show delays in hours instead of seconds
  • use end times for backups instead of start times for delays
  • improved logging
  • allow piping the results directly into nagios, to work around timeout issues

Unfortunately, i did the refactoring first and merged all the other good stuff after so this is only one big merge request as opposed to multiple small ones (which I understand would be preferable for easier review). But I was told that only Koumbit uses that script so that shouldn't be much of an issue.

Furthermore, during our tests, it shows no major behavior change in the actual output: some status strings change (as the status is added in all cases) but that shouldn't affect state in nagios.

Merge request reports