Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
G
GPSTk
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 17
    • Merge Requests 17
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SGL-UT
  • GPSTk
  • Issues
  • #53

Closed
Open
Opened Dec 20, 2018 by Bryan Parsons@masamitsutech🎮Developer

Assert failing in debug build for MSVC 2017 14.1

Created by: Drazuam

There's an issue with FFTextStream.cpp looking at memory before it's char buffer, which is throwing an exception on debug builds in windows. Looks like it probably wouldn't be much of an issue on a "dumber" build or system that's not checking these types of things.

Simple fix though. line 157:

https://github.com/SGL-UT/GPSTk/blob/997d97d20df6aedfa018d39a8b5bfaf234368fd9/core/lib/FileHandling/FFTextStream.cpp#L157 needs to change to: while (line[0]!='\0' && *line.rbegin() == '\r')

This will cause the while to exit before it can check the rbegin() function, and it wont access memory wrongly.

Edit: I made this change and it solved the issue for me locally

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: sgl-ut/GPSTk#53