Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
G
GPSTk
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 17
    • Merge Requests 17
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SGL-UT
  • GPSTk
  • Issues
  • #49

Closed
Open
Opened Oct 01, 2018 by Bryan Parsons@masamitsutech🎮Developer

No return in non void function

Created by: wkazubski

In function: bool RationalizeRinexNav::writeOutputFile in file core/lib/GNSSEph/RationalizeRinexNav.cpp there is no return at the end (around line 131 of the file). The function compiles OK but quality check on openSUSE build system catches this: ... [ 114s] I: Program returns random data in a function [ 114s] E: gpstk no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/GPSTk-2.10.6/core/lib/GNSSEph/RationalizeRinexNav.cpp:132 ... as it may return random data, making the program unstable. This error is treated so serious, that built binaries are discarded. Earlier this function returns false if something happened. Should it return true if it reaches the end?

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: sgl-ut/GPSTk#49