You need to sign in or sign up before continuing.
Update to tokio 1.0
tokio
has released version 1.0
almost a year ago, and the ecosystem (and our dependencies hyper
and hyper-tls
) has updated to use it.
We should, too, to keep compatible.
I successfully updated ffi
, net
and sq
(!1159 (merged)).
And I made an attempt at ipc
and store
(https://gitlab.com/sequoia-pgp/sequoia/-/commits/nora/tokio10), but I haven't made it work yet
- The
store
tests time out (https://gitlab.com/sequoia-pgp/sequoia/-/jobs/1815060816) - The gpg-agent tests (
cargo test -p sequoia-ipc --test gpg-agent
) fail on my machine (log) but succeed in CI (https://gitlab.com/sequoia-pgp/sequoia/-/jobs/1815060813)
Notable changes:
- in
ipc/assuan/mod.rs
:-
tokio::io::AsyncRead::poll_read
takes atokio::io::ReadBuf
now, use that and write to the Client's buffer later -
Poll::Ready
does not reportn_read
, so there can't be a conflict between the reported and actual number of bytes read. I removed the case.
-
- Every occurence:
- Replace
tokio::runtime::Builder::new().basic_scheduler()
withtokio::runtime::Builder::new_current_thread()
. I think this is the right choice, astokio 0.2
's basic scheduler only uses the current thread (see docs).
- Replace
I'd be grateful for hints where to look and how to debug this :)