Refactor the toggle_property_saving method of quiddity's to something that is easier to understand at a glance
The actual behaviour of the function is as follows :
/**
* When called with a property name, this will add or remove the property from
* the properties_blacklist_. Properties that are in the properties_blacklist_ will
* not be serialized when a call to \ref switcher::Switcher::get_state is made.
* The properties_blacklist_ starts out empty which means the first call to this function
* will always prevent the refered property from being serialized
*
* \param prop name of the property
*
* \return true if the property was removes from the properties_blacklist_ (which means it
* will be saved) and false if the property was inserted in the properties_blacklist_ (which
* means it will no longer be saved)
*/
bool toggle_property_saving(const std::string& prop_name);
This is very confusing and should be refactored, probaly to something like void set_property_saving(bool value)
That would simply make the quiddity savable or not depending on the boolean value.
This would be a breaking change to switcher and would affect +- 10 function calls in the codebase.
See this discussion !544 (comment 1274605511)