馃悰 If a user enters an invalid URI in the NewContactModal, the modal will close without adding the contact, but no information will be given to the user.
Summary
If a user enters an invalid URI in the NewContactModal, the modal will close without adding the contact, but no information will be given to the user.
Versions used to reproduce issue
(Indicate all relevant information about your system, including as many details as possible.) (Most importantly, specify which version of the software you are using.)
- are you using ScenicOS?
-
Yes - ScenicOS version: scenicos-focal-amd64-x86-64-1.0.0-build133-be323984-2022-08-22-1734 (cat /image_version)
-
No - linux distribution: Ubuntu 20.04.5 LTS (lsb_release -sd)
- system info: Linux ubuntu 5.4.0-126-generic #142 (closed)-Ubuntu SMP Fri Aug 26 12:12:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux (uname -a)
-
-
required versions - shmdata: 1.3.70
- ndi2shmdata: 0.6.0
- switcher: develop@942b299b (Sep 30, 2022 2:16pm GMT-0400)
- scenic-core: 4.0.6
- scenic: 4.0.8 (scenic-app.ca)
-
if it is related to QA tests: - scenic-selenium: develop@a6c0fcde (Sep 26, 2022 12:11pm GMT-0400)
-
if this bug occurred during a SIP call: - sip-server: dev.sip.scenic.sat.qc.ca/2.1.0
-
other versions - python: 3.8.10 (python3 --version)
- python-socketio: 5.7.1 (pip list | grep python-socketio)
Steps to reproduce
- Launch Scenic
- Log into SIP
- Click the Add Contact button
- Enter an invalid URI into the URI field (use spaces, for instance)
- Click Add Contact
What is the current bug behavior?
The modal will close and no contact will be added
What is the expected correct behavior?
Ideally, the URI field could be highlighted red and the the Modal will not close, allowing the user to correct their error.
What is the frequency of occurrence of this behavior ?
100%
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code, as it's very hard to read otherwise.)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
Additional comments
(Add references to related issues and provide any extra comments.)
/cc @flecavalier