Remove deprecated features in Sardana 3
Since we are approaching a major version number release we would like to remove some features deprecated long time ago.
This issue is to discuss if we all agree on it.
I have reviewed the whole code and found the following features marked as deprecated. I think we can remove all of them since the deprecation period is very long. The data source deprecations (32-37) are maybe too early to be removed - only one release of deprecation warning. But if no one comments here I would remove them as well.
Number | Deprecated | Deprecated since | Sugested substitute |
---|---|---|---|
1 | sardana.release.version_info | 2.2.0 | sardana.release.version |
2 | sardana.release.revision | 2.2.0 | sardana.release.version |
3 | sardana.release.revision | 2.2.0 | sardana.release.version |
4 | ParamRepeat | 2011 | param_def in lists |
5 | GSF generator yields hooks | 2011 | GSF generator yields specific hooks e.g. post-acq-hooks |
6 | pre-start hook place in ascanct scans | 2018 | pre-acq hook place in ascacnt scans |
7 | FileRecorder macro hints | Jan16 | ScanRecorder environment variable |
8 | Controller.class_prop | 1.0 | Controller.ctrl_properties |
9 | Controller.ctrl_extra_attributes | 1.0 | Controller.axis_attributes |
10 | Controller.inst_name | 1.0 | Controller.GetName |
11 | Controller.SetPar | 1.0 | Controller.SetAxisPar |
12 | Controller.GetPar | 1.0 | Controller.GetAxisPar |
13 | Controller.GetExtraAttributePar | 1.0 | Controller.GetAxisExtraPar |
14 | Controller.SetExtraAttributePar | 1.0 | Controller.SetAxisExtraPar |
15 | CounterTimerController._trigger_type | Jan17 (SEP6) | CounterTimerController._synchronizarion |
16 | CounterTimerController.PreStartAllCT | 1.0 | CounterTimerController.PreStartAll |
17 | CounterTimerController.PreStartOneCT(axis) | 1.0 | CounterTimerController.PreStartOne(axis, value) |
18 | CounterTimerController.StartAllCT | 1.0 | CounterTimerController.PreStartAll |
19 | CounterTimerController.PreStartOneCT(axis) | 1.0 | CounterTimerController.PreStartOne(axis, value) |
20 | PseudoMotorController.calc_all_pseudo | 1.0 | PseudoMotorController.CalcAllPseudo |
21 | PseudoMotorController.calc_all_physical | 1.0 | PseudoMotorController.CalcAllPhysical |
22 | PseudoMotorController.calc_pseudo | 1.0 | PseudoMotorController.CalcPseudo |
23 | PseudoMotorController.calc_physical | 1.0 | PseudoMotorController.CalcPhysical |
24 | PseudoCounterController.calc | 1.0 | PseudoCounterController.Calc |
25 | IORegisterController.predefined_values | 1.0 | IORegisterController.axis_attributes |
26 | TimerableController.PreLoadOne(axis, value) | 2.3.0 | TimerableController.PreLoadOne(axis, value, repetitions, latency) |
27 | TimerableController.LoadOne(axis, value) | 2.3.0 | TimerableController.LoadOne(axis, value, repetitions, latency) |
28 | MeasurementGroup.Configuration with non URI element/controller names | Jan19 | set configuration or recreate measurement group |
29 | MeasurementGroup.Configuration with trigger_type parameter | Jan18 | use synchronization parameter |
30 | MeasurementGroup.Start without prior Prepare | Jan18 | Prepare and then Start |
31 | Controller.ctrl_properties with "Descritpion" | Jul18 | Controller.ctrl_properties with sardana.pool.controller.Description |
32 | OneDController data_source axis par | Jul19 | Inherit from Referable class |
33 | TwoDController data_source axis par | Jul19 | Inherit from Referable class |
34 | OneDExpChannel DataSource attribute | Jul19 | ValueRef attribute |
35 | TwoDExpChannel DataSource attribute | Jul19 | ValueRef attribute |
36 | Pool1DExpChannel data_source property | Jul19 | value_ref property |
37 | Pool2DExpChannel data_source property | Jul19 | value_ref property |
38 | DiscretePseudMotor Label and Calibration axis attributes | 2.5.0 | Configuration axis attribute |
39 | sardana.spock.release module | Jul17 | sardana.release module |
40 | IPython < 1.0 genutils | 2.8.0 | Upgrade to IPython > 1.0 and Python 3 |
41 | Door Abort command | 2012 | Door StopMacro or AbortMacro command |
42 | Controller.getUsedAxis (taurus) | 2.5.0 | Controller.getUsedAxes |
43 | DoorAttrListener class (previously used in DoorOutput widgets) | 2.5.1 | QDoor |
44 | MacroButton.updateMacroArgumentFromSignal | 2014 | |
45 | MacroButton.connectArgEditors | 2014 | pyqtSignal objects |
46 | MacroButton.toggleProgress | 2014 | MacroButton.showProgress |
47 | PoolMotorSlim widget | 2.5.0 | PoolMotorTaurusValue |
48 | TimerableController.PreLoadOne(axis, value, repetitions) | 2.7.0 | TimerableController.PreLoadOne(axis, value, repetitions, latency) |
49 | TimerableController.LoadOne(axis, value, repetitions) | 2.7.0 | TimerableController.LoadOne(axis, value, repetitions, latency) |
Please raise your hand if you really need them and can not move forward to the suggested substitutes.