1. 01 Aug, 2018 3 commits
  2. 18 Jul, 2018 3 commits
  3. 17 Jul, 2018 3 commits
    • jim warner's avatar
    • jim warner's avatar
      top: parent total cpu includes collapsed children, pgm · 3da73186
      jim warner authored
      Now, when a parent's children have been collapsed, the
      cpu used by those unseen tasks will disappear no more.
      Instead such tics will be added to the parent's total.
      
      [ if one wished a return to the 'land of lost tics', ]
      [ the '#define TREE_VCPUOFF' directive is available. ]
      
      ------------------------------------------------------
      Note: With collapsible parents now displaying children
      cpu usage, it will eventually be noticed the cpu stats
      for the summary area and task areas often vary widely.
      
      It's worth a reminder that for top's summary area each
      individual cpu and the cpu summary is limited to 100%,
      regardless of how many tics a linux kernel may export.
      
      An individual task is limited to 100% times the number
      of threads. But, in no case will cpu usage ever exceed
      100% times total number of processors. Such limits are
      further reduced under 'Solaris' mode ('I' toggle off).
      In this mode, a task cpu usage will never exceed 100%.
      These limits will now also apply to collapsed parents.
      
      In addition to those influences, results are subjected
      to kernel timer sampling anomalies and the distortions
      inherent in a small sample size, made worse by smaller
      delay intervals. Often there is just 1 or 2 tics for a
      few tasks at smaller intervals such as: 1/10th second.
      
      Anyway, should questions on this subject arise, a good
      starting point, beyond the reminders above, is the 1st
      link listed below. Those other links were derivatives.
      
      Reference(s):
      . from the kernel documentation
      https://www.kernel.org/doc/Documentation/cpu-load.txt
      . as mentioned in the above kernel documentation
      https://lkml.org/lkml/2007/2/12/6
      . from above, with many more links on the subject
      https://www.boblycat.org/~malc/apc/Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      
      top: parent total cpu includes collapsed children, pgm
      3da73186
    • jim warner's avatar
      top: a refactor to prepare for including collapsed cpu · e66c3679
      jim warner authored
      So that the impact (minimal) of the next commit can be
      isolated, this commit just involves a little renaming,
      reformat plus a refactor of some proc_t pointer logic.
      
      [ renaming, relocation and changes to 'user_matched' ]
      [ wasn't strictly necessary, but now mirrors newlib. ]
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      e66c3679
  4. 26 Jun, 2018 1 commit
    • jim warner's avatar
      top: a few tweaks for those scrolling (mostly) changes · c6e68e2f
      jim warner authored
      This patch just addresses some edge cases with respect
      to 'unseen' tasks. Given the ability to preserve other
      filters in the rcfile, it's entirely possible the very
      first task(s) may not be visible at top startup. Also,
      when switching between windows ('a'/'w') we should try
      to always position its row #1 on some visible process.
      
      Lastly, a window might have *NO* visible tasks at all.
      Therefore, protect 'window_hlp' from an infinite loop.
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      c6e68e2f
  5. 23 Jun, 2018 15 commits
  6. 13 Jun, 2018 10 commits
  7. 07 Jun, 2018 3 commits
  8. 31 May, 2018 2 commits
    • jim warner's avatar
      library: avoid problems involving 'supgid' mishandling · f9a8009e
      jim warner authored
      Following that patch referenced below, the top SUPGRPS
      field would produce a segmentation fault and ps SUPGRP
      would often show "(null)". Such problems resulted from
      some faulty logic in the status2proc() routine dealing
      with 'Groups' (supgid) which served as a source field.
      
      For many processes the original code produced an empty
      string which prevented conversion to the expected "-".
      Moreover, prior to release 3.3.15 such an empty string
      will become 0 after strtol() which pwcache_get_group()
      translates to 'root' yielding very misleading results.
      
      So, now we'll check for empty '/proc/#/status/Groups:'
      fields & consistently provide a "-" value for callers.
      
      [ we'll also protect against future problems in that ]
      [ new qualys logic by always ensuring valid 'supgrp' ]
      [ pointers - logic which revealed our original flaw! ]
      
      Reference(s):
      . original qualys patch
      0071-proc-readproc.c-Harden-supgrps_from_supgids.patch
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      f9a8009e
    • Bjarni Ingi Gislason's avatar
      docs: Tidying of ps,kill and skill manpages · 336d4ab9
      Bjarni Ingi Gislason authored
      Some minor tidying of these three man pages using more of the modern
      (ish) macros that have been around for a while.
      
      References:
       https://bugs.debian.org/893452
       https://bugs.debian.org/893457
       https://bugs.debian.org/894480Signed-off-by: Craig Small's avatarCraig Small <csmall@enc.com.au>
      336d4ab9