Regression: "Preview window redesigned" broke several things
Merge request !10 (merged) e.g. commit b6140dfe introduced at least following breakage:
- Selection coordinates (top left and bottom right) are not properly validated to check that tl_x < br_x and tl_y < br_y (and if not, swapped), thus causing various places which assume it to be so, to break. One example is that the area size can become negative if you draw the selection starting from bottom-right to top-left.
This will also cause the scanning operation to fail with an error as the incorrectly calculated parameters are sent to the scanner.
-
Trying to adjust the selection when the original selection has been made "inversely" as above, will cause the selection to "reset" (basically a side-effect of the lack of checking of the coordinates).
-
Also, trying to adjust the selection when rotation is something else than 0, for example 90 degrees, the controls for the selection box do not work correctly. Moving any of the corners works as expected, but trying to move one of the selection box edges will trigger the move event as if the view would be unrotated.
Edited by Matti Hämäläinen