Commit 0c4cd772 authored by Anton Smirnov's avatar Anton Smirnov
Browse files

Call static methods statically

parent e6f6afcf

tests/BigIntTypeTest.php

+3 −3
Original line number Diff line number Diff line
@@ -13,19 +13,19 @@ class BigIntTypeTest extends TestCase 
    public function testPositiveNumericString()

    {

        $int = new BigIntType('123');

        $this->assertEquals('123', $int->getValue());

        self::assertEquals('123', $int->getValue());

    }



    public function testNegativeNumericString()

    {

        $int = new BigIntType('-123');

        $this->assertEquals('-123', $int->getValue());

        self::assertEquals('-123', $int->getValue());

    }



    public function testZero()

    {

        $int = new BigIntType('0');

        $this->assertEquals('0', $int->getValue());

        self::assertEquals('0', $int->getValue());

    }



    public function testNoPlus()

tests/DecodeDictTest.php

+3 −3
Original line number Diff line number Diff line
@@ -15,12 +15,12 @@ class DecodeDictTest extends TestCase 
    public function testValid()

    {

        // simple

        $this->assertEquals(['a' => 'b', 'c' => 'd'], Bencode::decode('d1:a1:b1:c1:de'));

        self::assertEquals(['a' => 'b', 'c' => 'd'], Bencode::decode('d1:a1:b1:c1:de'));

        // numeric keys

        // php converts numeric array keys to integers

        $this->assertEquals([1 => 2, 3 => 4], Bencode::decode('d1:1i2e1:3i4ee'));

        self::assertEquals([1 => 2, 3 => 4], Bencode::decode('d1:1i2e1:3i4ee'));

        // empty

        $this->assertEquals([], Bencode::decode('de'));

        self::assertEquals([], Bencode::decode('de'));

    }



    public function testKeyNotString()

tests/DecodeIntegerTest.php

+3 −3
Original line number Diff line number Diff line
@@ -18,9 +18,9 @@ class DecodeIntegerTest extends TestCase 
    public function testValid()

    {

        // valid values

        $this->assertEquals(213, Bencode::decode('i213e'));

        $this->assertEquals(-314, Bencode::decode('i-314e'));

        $this->assertEquals(0, Bencode::decode('i0e'));

        self::assertEquals(213, Bencode::decode('i213e'));

        self::assertEquals(-314, Bencode::decode('i-314e'));

        self::assertEquals(0, Bencode::decode('i0e'));

    }



    public function testEmptyValue()

tests/DecodeIntegrationTest.php

+3 −3
Original line number Diff line number Diff line
@@ -52,8 +52,8 @@ class DecodeIntegrationTest extends TestCase 
            'dictionaryType' => 'object',

        ]);



        $this->assertEquals($value, $decoded);

        $this->assertEquals(ArrayObject::class, get_class($decoded[3]));

        $this->assertEquals(stdClass::class,    get_class($decoded[4]));

        self::assertEquals($value, $decoded);

        self::assertEquals(ArrayObject::class, get_class($decoded[3]));

        self::assertEquals(stdClass::class,    get_class($decoded[4]));

    }

}

tests/DecodeListTest.php

+13 −13
Original line number Diff line number Diff line
@@ -17,13 +17,13 @@ class DecodeListTest extends TestCase 
    public function testListSimple()

    {

        // of integers

        $this->assertEquals([2, 3, 5, 7, 11, 13], Bencode::decode('li2ei3ei5ei7ei11ei13ee'));

        self::assertEquals([2, 3, 5, 7, 11, 13], Bencode::decode('li2ei3ei5ei7ei11ei13ee'));

        // of strings

        $this->assertEquals(['s1', 's2'], Bencode::decode('l2:s12:s2e'));

        self::assertEquals(['s1', 's2'], Bencode::decode('l2:s12:s2e'));

        // mixed

        $this->assertEquals([2, 's1', 3, 's2', 5], Bencode::decode('li2e2:s1i3e2:s2i5ee'));

        self::assertEquals([2, 's1', 3, 's2', 5], Bencode::decode('li2e2:s1i3e2:s2i5ee'));

        // empty

        $this->assertEquals([], Bencode::decode('le'));

        self::assertEquals([], Bencode::decode('le'));

    }



    public function testListTypes()
@@ -34,34 +34,34 @@ class DecodeListTest extends TestCase 
        // array

        $decodedArray = Bencode::decode($encoded, ['listType' => 'array']);



        $this->assertTrue(is_array($decodedArray));

        $this->assertEquals($list, $decodedArray);

        self::assertTrue(is_array($decodedArray));

        self::assertEquals($list, $decodedArray);



        // stdClass

        $object = (object)$list;

        $decodedObject = Bencode::decode($encoded, ['listType' => 'object']);



        $this->assertEquals(stdClass::class, get_class($decodedObject));

        $this->assertEquals($object, $decodedObject);

        self::assertEquals(stdClass::class, get_class($decodedObject));

        self::assertEquals($object, $decodedObject);



        // custom class

        $arrayObject = new ArrayObject($list);

        $decodedAO = Bencode::decode($encoded, ['listType' => ArrayObject::class]);



        $this->assertEquals(ArrayObject::class, get_class($decodedAO));

        $this->assertEquals($arrayObject, $decodedAO);

        self::assertEquals(ArrayObject::class, get_class($decodedAO));

        self::assertEquals($arrayObject, $decodedAO);



        // callback

        // use same array object as above

        $decodedCallback = Bencode::decode($encoded, ['listType' => function ($array) use($list) {

            $this->assertEquals($list, $array); // check thar array is passed here

            self::assertEquals($list, $array); // check thar array is passed here



            // you can pass extra parameter to the constructor for example

            return new ArrayObject($list, ArrayObject::ARRAY_AS_PROPS);

        }]);



        $this->assertEquals(ArrayObject::class, get_class($decodedCallback));

        $this->assertEquals($arrayObject, $decodedCallback);

        self::assertEquals(ArrayObject::class, get_class($decodedCallback));

        self::assertEquals($arrayObject, $decodedCallback);

    }



    public function testIncorrectType()