• Tim Beale's avatar
    netcmd: Fix passwordsettings --max-pwd-age command · 893ac2a6
    Tim Beale authored
    The min_pwd_age and max_pwd_age parameters are both optional and default
    to None. However, if we just set the max-pwd-age, then the check
    'min_pwd_age >= max_pwd_age' will throw a Python exception because it's
    trying to compare an int to NoneType (min_pwd_age). This works on Python 2
    but is a problem on Python 3.
    
    We could just add a check that min_pwd_age is not None, but that defeats
    the point of having the check if you're only setting either the min or
    max age indepedently.
    
    This patch gets the current min/max password age from the DB (in ticks).
    If either setting is changed, the ticks will be updated. Then at the end
    we check the min is still less than the max (to do this, we convert the
    ticks back to days in the interests of readability).
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13873Signed-off-by: Tim Beale's avatarTim Beale <[email protected]>
    Reviewed-by: Andrew Bartlett's avatarAndrew Bartlett <[email protected]>
    
    Autobuild-User(master): Andrew Bartlett <[email protected]>
    Autobuild-Date(master): Fri Apr  5 08:03:08 UTC 2019 on sn-devel-144
    
    (cherry picked from commit 7a410ccb)
    
    Autobuild-User(v4-10-test): Karolin Seeger <[email protected]>
    Autobuild-Date(v4-10-test): Tue May 14 17:36:28 UTC 2019 on sn-devel-144
    893ac2a6
domain.py 196 KB