Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • The Samba Team
  • SambaSamba
  • Merge requests
  • !535

regfio: Return instead of assert for short blocks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Andrew Bartlett requested to merge samba-team/devel/samba:abartlet-hansmi-regfio-15088 into master Jun 11, 2019
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

Assertions should only be used when there's absolutely no recovery or to verify data structure invariants. In this case the supplied registry hive file may have a malformed block with a size of zero. Such a block should not terminate the whole program.

Signed-off-by: Michael Hanselmann public@hansmi.ch Reviewed-by: Andrew Bartlett abartlet@samba.org

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: abartlet-hansmi-regfio-15088