vfs_ceph_snapshots: Prepend connectpath to full snapshot path from dirfsp

Anoop C Srequested to merge
samba-team/devel/samba:anoopcs-vfs-ceph-snapshots-subdir-snapshot-fixes into master

There is a situation with ceph_snap_gmt_convert_dir() where we might end up opening the wrong snapdir for reading the snapshots. This is due to the fact that we calculate the parent as empty string via ceph_snap_get_parent_path() for a file inside a directory under share root. In addition to that we follow the logic from shadow_copy2 module to return the converted snapshot path corresponding to file share's root.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15819

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Anoop C S

Merge request reports