Skip to content

transitive comaprison functions part 3

Douglas Bagnall requested to merge samba-team/devel/samba:douglas-transitive-comparisions-3 into master

This lot has diversions. Because of changes to ldif_comparison_objectSid(), we end up making ldb finally accept lowercase s-1-2-3 SIDs and fix the sid strings tests.

ldb_comparison_fold() is still not transitive, and I don't think it is really possible to fix it without adding a strncasecmp-like function to the ldb->utf8_fns struct.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Andrew Bartlett

Merge request reports