Skip to content

oLschema2ldif: Resolve multiple parsing bugs

Andrew Bartlett requested to merge samba-team/devel/samba:abartlet-hansmi-oLschema2ldif into master

The "oLschema2ldif" program contained multiple bugs triggered by malformed inputs:

  • Iteration beyond list of recognized dsdb syntax OIDs when value wasn't found (bug 9567)
  • NULL pointer dereference when input didn't define a name
  • Heap buffer overflows for unterminated token values

Tests are added to reproduce all identified bugs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9567

Signed-off-by: Michael Hanselmann public@hansmi.ch

Then adapted to use ARRAY_SIZE() consistently as suggested by metze.

Signed-off-by: Andrew Bartlett abartlet@samba.org

Merge request reports