Skip to content

smbget: Fix interactive password retrieval with smburl and the complete testsuite

Andreas Schneider requested to merge samba-team/devel/samba:asn-smbget into master

Most of the smbget tests didn't work as the [smbget] share had set guest ok = yes. So with incorrect username tests just passed, as users were authenticated as guest. The first patches address this.

The second part fixes issues in credentials and the password dialog.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports