Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Merge requests 163
    • Merge requests 163
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • The Samba TeamThe Samba Team
  • SambaSamba
  • Merge requests
  • !2492

Don't use fsp_get_io_fd() to check if it's a pathref fd to refuse to grant a durable handle.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Jeremy Allison requested to merge samba-team/devel/samba:jra-fix-bug-15042 into master Apr 15, 2022
  • Overview 9
  • Commits 2
  • Pipelines 2
  • Changes 3

Currently we don't grant durable handle requests on opens for meta-data only (what we used to call "stat" opens, where we only have an O_PATH open fd). To refuse, we should check the fsp_flags.is_pathref flag directly, not call (fsp_get_io_fd(fsp) == -1). fsp_get_io_fd() will emit a scary error message if it wasn't a pathref fd and this isn't a fatal error, we're just using it to deny a durable handle open.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15042

Fix confirmed by submitter. Passes ci.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jra-fix-bug-15042