Skip to content

GitLab

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Merge requests 138
    • Merge requests 138
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar

GitLab 15.0 has launched! Please visit Breaking changes in 15.0 and 15.0 Removals to see which breaking changes may impact your workflow.

  • The Samba Team
  • SambaSamba
  • Merge requests
  • !2271

Draft: DNS updates allow/deny for SAMBA_INTERAL dns server.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Matthew Grant requested to merge samba-team/devel/samba:grantma/dns-updates-allow-deny into master Nov 25, 2021
  • Overview 1
  • Commits 5
  • Pipelines 2
  • Changes 12

Preview merge request for comment. Want comment on code changes, and what tests are required for Smab test suite.

Mechanism for DNS update host/rrnet allow/deny lists. Three functions dns_update_check_access(), dns_update_get_caddr() (gets subject address for check from A, AAAA, and PTR records), and dns_update_ipaddr_check_access() are backended by allow_access_flag_lo() from lib/util/access.c using the already existing host allow/deny access mechanism.

Checklist

  • [*] Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: grantma/dns-updates-allow-deny