This DRAFT MR for discussion about the process to finally upgrade the internal Samba fork of Heimdal.
Based on the work that has been a ping-pong between @metze @iboukris @lockyergw and myself over the years.
I've worked to tidy up @metze's master-heimdal branch from 2020-08 after a rebase on current master and it is getting closer to being ready (but still much more to do).
TODO: Understand the new GSS-preauth thing and what the implications for auditing are
The process with the MR is to prepare a lorikeet-heimdal branch, based on each successive tree in https://gitlab.com/samba-team/devel/lorikeet-heimdal and then import that, followed by the build and test fixes needed to make it work. Ideally these get merged first, as knownfail or 'pointless' changes (eg to add defines or cflags), but otherwise after the import.
Checklist
-
Commits have Signed-off-by:with name/author being identical to the commit author -
(optional) This MR is just one part towards a larger feature. -
(optional, if backport required) Bugzilla bug filed and BUG:tag added -
Test suite updated with functionality tests -
Test suite updated with negative tests -
Documentation updated -
CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)
Reviewer's checklist:
-
There is a test suite reasonably covering new functionality or modifications -
Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md -
This feature/change has adequate documentation added -
No obvious mistakes in the code