Skip to content

fix multi-channel binding checks (bug #14512)

Stefan Metzmacherrequested to merge
samba-team/devel/samba:metze-multichannel into master

This was triggered by https://bugzilla.samba.org/show_bug.cgi?id=14512 (Fix MultipleChannel_Negative_SMB2002)

Most of it is preparation work in order to allow the tests to run correctly against Windows.

As a side effect it will be much easier to add new values to SMB2_ENCRYPTION_CAPABILITIES (AES-256-GCM/CCM) as well as adding support for SMB2_SIGNING_CAPABILITIES (to negotite HMAC-SHA256, AES-128-CMAC and AES-128-GMAC) in future.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports