Npower fix tar

Closed Noel Power requested to merge samba-team/devel/samba:npower_fix_tar into master


commit 31753815 introduced this issue which unfortunately is not spotted by CI because the tarmode tests are marked as flapping (Additionally the tar tests are also currently broken and again because they are marked as flapping we missed that too so you can't run the tests manually)

This merge gets the broken tar test working again (but doesn't remove it from the flapping list)

so, post these changes at least if you comment out the entry in selftest/flapping you can at least run the test manually

[1(0)/4 at 0s] samba3.blackbox.smbclient_tarmode.NT1(fileserver_smb1_done)
[2(2)/4 at 9s] samba3.blackbox.smbclient_tarmode.SMB3(fileserver)
[3(4)/4 at 18s] samba3.blackbox.smbclient_tar.NT1(fileserver_smb1_done)
[4(26)/4 at 36s] samba3.blackbox.smbclient_tar.SMB3(fileserver)


  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports