Skip to content

GitLab

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    • Menu
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Merge requests 134
    • Merge requests 134
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • The Samba Team
  • SambaSamba
  • Merge requests
  • !1408

nsswitch: silence openpam error messages about unexpected responses

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Andrew Walker requested to merge samba-team/devel/samba:anodos325-pam_winbind-silence-openpam-errors into master Jun 19, 2020
  • Overview 6
  • Commits 1
  • Pipelines 3
  • Changes 1

Openpam will log an error message when it receives an unexpected response. On servers using openpam, convert an unexpected response into PAM_SERVICE_ERR and log what we're doing so that logging behavior is more user-configurable.

Sample error message: openpam_check_error_code(): pam_sm_setcred(): unexpected return value 12

https://bugzilla.samba.org/show_bug.cgi?id=14416

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited Jun 22, 2020 by Andreas Schneider
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: anodos325-pam_winbind-silence-openpam-errors