Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Merge requests 138
    • Merge requests 138
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • The Samba Team
  • SambaSamba
  • Merge requests
  • !1284

dbwrap_watch: Set rec->value_valid while returning nested share_mode_do_locked()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Anoop C S requested to merge samba-team/devel/samba:anoopcs-dbwrap_watch-rec-value_valid into master Apr 20, 2020
  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 1

As reported on samba-technical by Rouven WEILER Rouven_Weiler@gmx.net:

For the backtrace mentioned in the commit i.e, in case of nested share_mode_do_locked() invocation, callback comes through dbwrap_watched_do_locked_fn() where it fails to update rec->value_valid which further gets assigned to static_share_mode_record within share_mode_do_locked_fn(). Following that assertion on rec->value_valid fails via dbwrap_record_get_value() inside get_static_share_mode_data().

Edited Apr 20, 2020 by Anoop C S
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: anoopcs-dbwrap_watch-rec-value_valid