Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Merge requests 156
    • Merge requests 156
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • The Samba TeamThe Samba Team
  • SambaSamba
  • Merge requests
  • !1043

vfs_ceph: assert renameat() fsps match cwd

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed David Disseldorp requested to merge samba-team/devel/samba:ddiss/vfs_ceph_assert_renameat_cwd into master Jan 09, 2020
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

As discussed with Jeremy in bug 14232, the vfs_ceph.renameat_fn implementation currently ignores srcfsp and dstfsp. As a result, relative smb_fname_src/smb_fname_dest paths will be processed as relative to cwd. This is currently a valid assumption, as srcfsp and dstfsp should always match conn->cwd_fsp. Add an assert to clarify this.

Signed-off-by: David Disseldorp ddiss@samba.org

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ddiss/vfs_ceph_assert_renameat_cwd