Commits · master · The Samba Team / Samba

This project is mirrored from https://git.samba.org/samba.git. Pull mirroring updated Aug 17, 2022.

07 Feb, 2022 4 commits
- libsmb: Convert SMBC_getatr() to NTSTATUS · d4f8fdd6
  VL authored Jan 21, 2022 and Jeremy Allison committed Feb 07, 2022
```
This avoids a few calls to SMBC_errno()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
  d4f8fdd6
- libsmb: Avoid a call to SMBC_errno() · 3844fe87
  VL authored Jan 21, 2022 and Jeremy Allison committed Feb 07, 2022
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
  3844fe87
- libsmb: Avoid two calls to SMBC_errno() · c78f0a96
  VL authored Jan 21, 2022 and Jeremy Allison committed Feb 07, 2022
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
  c78f0a96
- libsmb: Avoid a call to SMBC_errno() · 098fc00f
  VL authored Jan 21, 2022 and Jeremy Allison committed Feb 07, 2022
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
  098fc00f
06 Aug, 2021 2 commits

libsmbclient: Avoid a call to SMBC_errno() in SMBC_notify_ctx() · 1881240d
VL authored Dec 15, 2020 and Jeremy Allison committed Aug 06, 2021
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
1881240d

libsmbclient: Avoid a call to SMBC_errno() in SMBC_chmod_ctx() · 7c2b6a71

VL authored Dec 15, 2020 and

Jeremy Allison committed Aug 06, 2021



Directly use the return value from cli_setatr(), don't go via the cli_state
struct member
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

7c2b6a71

15 Jun, 2021 1 commit
- libsmbclient: Avoid a call to SMBC_errno() in SMBC_mkdir_ctx() · 5f5c45a1
  VL authored Dec 15, 2020 and Jeremy Allison committed Jun 15, 2021
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
  5f5c45a1
28 May, 2021 1 commit
- s3:libsmb: Use cli_credentials to store traversal creds · 84b5440e
  Andreas Schneider authored Jan 13, 2021 and Andrew Bartlett committed May 28, 2021
```
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
```
  84b5440e
01 Mar, 2021 1 commit
- s3:libsmb: fix a typo in a comment · 485743da
  Björn Baumbach authored Jan 21, 2021 and Andrew Bartlett committed Mar 01, 2021
```
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
```
  485743da
13 Jan, 2021 2 commits

s3:libsmb: Use cli_credentials directly · 181afa9f

Andreas Schneider authored Jan 13, 2021 and

VL committed Jan 13, 2021


Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Jan 13 21:32:52 UTC 2021 on sn-devel-184

181afa9f

s3:libsmb: Pass cli_credentials to get_ipc_connect_master_ip() · 78c4043a
Andreas Schneider authored Jan 13, 2021 and VL committed Jan 13, 2021
```
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
```
78c4043a

26 Nov, 2020 1 commit

s3:libsmb: Return early if dir is NULL · 1a864749

Andreas Schneider authored Nov 25, 2020 and

Andreas Schneider committed Nov 26, 2020



This makes sure we do not dereference a NULL poineter.

Found by covscan.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov 26 11:07:09 UTC 2020 on sn-devel-184

1a864749

04 Nov, 2020 1 commit

libsmb: Remove "mntpoint" argument from cli_list() callback · 4ebe72b9

VL authored Oct 19, 2020 and

Jeremy Allison committed Nov 04, 2020



do_list()/do_list_helper() in source3/client/client.c was the only user of this
argument. And that use was wrong.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

4ebe72b9

09 Oct, 2020 1 commit
- s3:libsmb: Pass cli_credentials to cli_resolve_path(), using helper variables. · 5245ab3c
  Andreas Schneider authored Aug 18, 2020 and Jeremy Allison committed Oct 09, 2020
```
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
```
  5245ab3c
15 Sep, 2020 1 commit

s3: libsmb: Convert the WINS and broadcast name functions to return size_t * num addresses. · af6aaf62

Jeremy Allison authored Sep 08, 2020



Have to do both at once as they are intimately related.
The uglyness inside internal_resolve_name() will go away
once all the resove_XXX() functions return size_t values.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <npower@samba.org>

af6aaf62

28 Aug, 2020 1 commit

s3: safe_string: do not include string_wrappers.h · c2ac923c

Matthew DeVore authored Aug 07, 2020 and

Jeremy Allison committed Aug 28, 2020



Rather than have safe_string.h #include string_wrappers.h, make users of
string_wrappers.h include it explicitly.

includes.h now no longer includes string_wrappers.h transitively. Still
allow includes.h to #include safe_string.h for now so that as many
modules as possible get the safety checks in it.
Signed-off-by: Matthew DeVore <matvore@google.com>
Reviewed-by: David Mulder <dmulder@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

c2ac923c

04 Aug, 2020 1 commit
- s3: libsmb: Cleanup - put talloc parameter first in name_resolve_bcast(). · eaea3c0a
  Jeremy Allison authored Jul 20, 2020
```
No logic changes.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
```
  eaea3c0a
04 Jun, 2020 3 commits

s3: libsmb: Change cli_setatr() and async version to use 32-bit attributes. · 8ad8a8f7

Jeremy Allison authored Jun 03, 2020



Fix the callers. Only sets 16 bits on the wire for this level.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

8ad8a8f7

s3: libsmb: SMBC_chmod_ctx(), rename mode -> attr when setting attributes. · a5f5cbc2
Jeremy Allison authored Jun 03, 2020
```
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
```
a5f5cbc2

s3: libsmb: In struct file_info rename mode -> attr. · 8db0ba66

Jeremy Allison authored Jun 03, 2020



Cleanup.  It's never been a UNIX mode, always a DOS attribute field.
Make that explicit.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

8db0ba66

25 May, 2020 3 commits

libsmb: Move a variable declaration closer to its use · 3cc45aae
VL authored Apr 20, 2020 and Andreas Schneider committed May 25, 2020
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
```
3cc45aae

libsmb: Simplify callers of SMBC_dlist_contains() · 4734b64e

VL authored Feb 21, 2020 and

Andreas Schneider committed May 25, 2020



This function already does the NULL check on the file pointer
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

4734b64e

libsmb: Align calls to SMBC_dlist_contains() · 66caa6b2

VL authored Feb 21, 2020 and

Andreas Schneider committed May 25, 2020



Everywhere else it's called as !SMBC_dlist_contains()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

66caa6b2

05 May, 2020 2 commits

libsmb: Add a NULL check · 2e3be139

VL authored Feb 21, 2020 and

Ralph Böhme committed May 05, 2020


Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

2e3be139

libsmb: Align integer types in net_share_enum_rpc() · 157554f3
VL authored Apr 20, 2020 and Ralph Böhme committed May 05, 2020
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
```
157554f3

08 Apr, 2020 2 commits

libsmb: Respect the full timeval for smbc_utimes() · cfd0a8a7
VL authored Mar 30, 2020 and Ralph Böhme committed Apr 08, 2020
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
```
cfd0a8a7

libsmb: Pass "struct timespec" to SMBC_setatr() · e4aa9a97

VL authored Mar 26, 2020 and

Ralph Böhme committed Apr 08, 2020



Prepare to set higher-precision timestamps. No change in behaviour so
far: The {.tv_nsec=SAMBA_UTIME_OMIT} implicitly sets .tv_sec=0, and
SMBC_setatr() only looks at .tv_sec
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

e4aa9a97

10 Mar, 2020 1 commit

libsmbclient: Put it back to a known, well-working state · 9653a107

VL authored Mar 10, 2020 and

Jeremy Allison committed Mar 10, 2020



For adapting unix extensions in our client libraries, we need a fresh start
with additional APIs. We can't change existing application behaviour.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

9653a107

03 Mar, 2020 1 commit
- libsmb: Use posix result in SMBC_readdirplus2_ctx · c2e012fe
  VL authored Feb 28, 2020 and Jeremy Allison committed Mar 03, 2020
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
  c2e012fe
25 Feb, 2020 3 commits

libsmb: Simplify callers of SMBC_dlist_contains() · d7281e32

VL authored Feb 21, 2020 and

Jeremy Allison committed Feb 25, 2020



This function already does the NULL check on the file pointer
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

d7281e32

libsmb: Align calls to SMBC_dlist_contains() · c3a2cc9b

VL authored Feb 21, 2020 and

Jeremy Allison committed Feb 25, 2020



Everywhere else it's called as !SMBC_dlist_contains()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

c3a2cc9b

libsmb: Add a NULL check · a4a96a90
VL authored Feb 21, 2020 and Jeremy Allison committed Feb 25, 2020
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
a4a96a90

19 Dec, 2019 2 commits

s3:libsmb: Return a 'struct stat' buffer for SMBC_getatr() · 0fe9dc52

Andreas Schneider authored Nov 25, 2019 and

Andreas Schneider committed Dec 19, 2019

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

0fe9dc52

s3:libsmb: Generate the inode only based on the path component · ea51a426

Andreas Schneider authored Dec 18, 2019 and

Andreas Schneider committed Dec 19, 2019

Currently we use the full smb url which includes also username and
password.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

ea51a426

05 Nov, 2019 1 commit

s3: libsmb: Ensure return from net_share_enum_rpc() sets cli->raw_status on error. · ff47cc66

Jeremy Allison authored Oct 31, 2019 and

Andreas Schneider committed Nov 05, 2019

Convert net_share_enum_rpc() to return an NTSTATUS and ensure the
status is set correctly on error so SMBC_errno() can return it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14176

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Nov  5 12:36:48 UTC 2019 on sn-devel-184

ff47cc66

30 Oct, 2019 3 commits

s3: libsmb: Added new API smbc_readdirplus2() · abbbbbff

Jeremy Allison authored Oct 18, 2019 and

Ralph Böhme committed Oct 30, 2019



Returns the same as smbc_readdirplus() but also
can return a struct stat if passed in by the caller.

struct stat is synthesized from the data
returned by the SMB server.
Signed-off-by: Puran Chand <pchand@vmware.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

abbbbbff

s3: libsmb: Add missing ino field to internal struct smbc_dirplus_list. · e26487aa

Jeremy Allison authored Oct 18, 2019 and

Ralph Böhme committed Oct 30, 2019



This should have been added to struct libsmb_file_info, but
this is user-visible so I don't want to change this now. Adding
it to the containing struct allows us to synthesise a struct stat
to return from smbc_readdirplus2() to return all the info from
the server to callers.
Signed-off-by: Puran Chand <pchand@vmware.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

e26487aa

s3: libsmb: Ensure we don't call cli_RNetShareEnum() on an SMB1 connection. · 1cfcad62
Jeremy Allison authored Oct 29, 2019 and Ralph Böhme committed Oct 30, 2019
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14174

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
```
1cfcad62

03 Sep, 2019 2 commits

s3: libsmbclient: Fix smbc_lseekdir() to work with smbc_readdirplus(). · 0d9b1645

Jeremy Allison authored Aug 26, 2019

If returning files the dir_list and the dirplus_list have exactly the same
entries, we just need to keep the next pointers in sync on seek.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>

0d9b1645

s3: libsmbclient: Ensure SMBC_getdents_ctx() also updates the readdirplus pointers. · 754cec77

Jeremy Allison authored Aug 26, 2019

If we are returning file entries, we
have a duplicate list in dirplus.

Update dirplus_next also so readdir and
readdirplus are kept in sync.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>

754cec77