Commits · master · The Samba Team / Samba

This project is mirrored from https://git.samba.org/samba.git. Pull mirroring updated Feb 01, 2023.

31 Jan, 2023 22 commits

s4-drsuapi: Give an error that matches windows on destination_dsa_guid lookup failure · 0f2978bb

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jan 31 13:43:54 UTC 2023 on atb-devel-224

0f2978bb

s4-drsuapi: Clarify role of drs_security_access_check_nc_root() · 1838f349

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

1838f349

s4-rpc_server: Pre-check destination_dsa_guid in GetNCChanges for validity · 115a3a10

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

This allows our new tests to pass as these need to be checked first.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

115a3a10

s4-drsuapi: Use samdb_get_ntds_obj_by_guid() to find RODC in REPL_SECRET · 09ec6a1d

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

We need to find the RODC per the destination_dsa_guid to mark the secrets as
having been replicated, and by using samdb_get_ntds_obj_by_guid() we are stricter
in the checks, as the RODC has to be the right objectClass (nTDSDSA) and under
the CN=Configuration partition.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

09ec6a1d

s4-dsdb: Require that the NTDS object is an nTDSDSA objectclass · adb77614

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

This should avoid a user being able to specify the GUID of a different
type of object.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

adb77614

s4-dsdb: Split samdb_get_ntds_obj_by_guid() out of samdb_is_rodc() · d5a2af3f

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

This will allow the logic here to be tighened up and shared
in the next few commits.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

d5a2af3f

s4-rpc_server/drsuapi: Return correct error code for an invalid DN to EXOP_REPL_OBJ/EXOP_REPL_OBJ · cbe18353
Andrew Bartlett authored Dec 16, 2022 and Stefan Metzmacher committed Jan 31, 2023
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
cbe18353

s4-drs: Make drs_ObjectIdentifier_to_dn() safer and able to cope with DummyDN values · 73f3ece8

Andrew Bartlett authored Jan 31, 2023 and

Stefan Metzmacher committed Jan 31, 2023

We want to totally ignore the string DN if there is a GUID,
as clients like "Microsoft Azure AD connect cloud sync" will
set a literal "DummyDN" string.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

73f3ece8

s4-dsdb: rework drs_ObjectIdentifier_to_dn() into drs_ObjectIdentifier_to_dn_and_nc_root() · aee2039e

Andrew Bartlett authored Dec 12, 2022 and

Stefan Metzmacher committed Jan 31, 2023

This make this funciton the gatekeeper between the wire format and the
internal struct ldb_dn, checking if the DN exists and which NC
it belongs to along the way, and presenting only a DB-returned
DN for internal processing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

aee2039e

s4-rpc_server/drsuapi: Use dsdb_normalise_dn_and_find_nc_root() · e96dfc74

Andrew Bartlett authored Dec 12, 2022 and

Stefan Metzmacher committed Jan 31, 2023

This reuses the search done for dsdb_find_nc_root() to normalise the DN.

This will allow a GUID-input DN to be compared safely with a RID Manager DN
or Naming Context.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

e96dfc74

s4-dsdb: Add dsdb_normalise_dn_and_find_nc_root() around dsdb_find_nc_root() · 8e112242

Andrew Bartlett authored Dec 12, 2022 and

Stefan Metzmacher committed Jan 31, 2023

Reuse the search done for dsdb_find_nc_root() to normalise the DN.

This will allow a GUID-input DN to be compared safely with a RID Manager DN
or Naming Context.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

8e112242

s4-dsdb: Add better debugging to dsdb_objects_have_same_nc() · 0f501b23

Andrew Bartlett authored Dec 15, 2022 and

Stefan Metzmacher committed Jan 31, 2023

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

0f501b23

s4-dsdb: Make dsdb_find_nc_root() first try and use DSDB_CONTROL_CURRENT_PARTITION_OID · d0444be4

Andrew Bartlett authored Dec 05, 2022 and

Stefan Metzmacher committed Jan 31, 2023

This allows lookup of a DN with a GUID only or GUID and string,
possibly not yet in the database, yet still getting the correct result.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

d0444be4

s4-dsdb: Schedule SD propegation only after successful rename · 7032b86c

Andrew Bartlett authored Jan 26, 2023 and

Stefan Metzmacher committed Jan 31, 2023

This avoids needing to anticipate errors that the rename might give
while allowing the dsdb_find_nc_root() routine to become stricter.

The problem is that dsdb_find_nc_root() will soon do a real search and
so fail more often, but these failures will give "wrong" error codes.

We do not need to do this work if the operation fails, so put this in
the callback.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

7032b86c

s4-selftest/drs: Confirm GetNCChanges REPL_SECRET works with a DummyDN and real GUID · 7c433885
Andrew Bartlett authored Dec 15, 2022 and Stefan Metzmacher committed Jan 31, 2023
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
7c433885
s4-selftest/drs: Confirm GetNCChanges full replication works with a DummyDN and real GUID · 539221dd
Andrew Bartlett authored Dec 15, 2022 and Stefan Metzmacher committed Jan 31, 2023
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
539221dd
s4-selftest/drs: Confirm GetNCChanges REPL_OBJ works with a DummyDN and real GUID · 70faccae
Andrew Bartlett authored Dec 02, 2022 and Stefan Metzmacher committed Jan 31, 2023
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
70faccae

s4-selftest/drs Allow re-run of DRS tests after failed cleanup · 3204d135

Andrew Bartlett authored Dec 02, 2022 and

Stefan Metzmacher committed Jan 31, 2023

Using a random base is a useful start, even if the better solution also includes a self.AddCleanup()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

3204d135

s4-selftest/drs Allow some DRS tests to operate against an IP · a150a2dc

Andrew Bartlett authored Dec 02, 2022 and

Stefan Metzmacher committed Jan 31, 2023

This is not comprehensive, but makes some manual test runs easier by
avoiding the need for DNS names to resolve.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

a150a2dc

s4-selftest/drs Add test of expected return code for invaid DNs in GetNCChanges · bee45e6b
Andrew Bartlett authored Dec 02, 2022 and Stefan Metzmacher committed Jan 31, 2023
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
bee45e6b

s4-dsdb: Add tests of SamDB.get_nc_root() · 2c7bb587

Andrew Bartlett authored Dec 15, 2022 and

Stefan Metzmacher committed Jan 31, 2023

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

2c7bb587

s4-dsdb: Rework dsdb_find_dn_by_guid() to use GUID_buf_string() · d43adae8

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023



This avoids a talloc_strdup() and so a failure path.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

d43adae8

30 Jan, 2023 16 commits

script:autobuild: Make sure we can send a failure mail · f6712c70

Andreas Schneider authored Jan 25, 2023 and

Andrew Bartlett committed Jan 30, 2023



We should not run into an exception if the file doesn't exist.

Traceback (most recent call last):
  File "script/autobuild.py", line 1781, in <module>
    email_failure(-1, 'rebase', 'rebase', 'rebase',
  File "script/autobuild.py", line 1677, in email_failure
    f = open("%s/%s.stdout" % (gitroot, failed_tag), 'r')
FileNotFoundError: [Errno 2] No such file or directory:
  'samba-autobuild/rebase.stdout'

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jan 30 10:00:27 UTC 2023 on atb-devel-224

f6712c70

python: Replace calls to deprecated methods · 41aa379a

Joseph Sutton authored Jan 19, 2023 and

Andrew Bartlett committed Jan 30, 2023



These aliases are deprecated and have been removed in Python 3.12.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

41aa379a

samba-tool: Use ntstatus constants in gpo commands · a15208f6

David Mulder authored Dec 07, 2022 and

Andrew Bartlett committed Jan 30, 2023



Replace all the hard coded instances of ntstatus
codes in the samba-tool gpo commands with
constants from samba.ntstatus.

Signed-off-by: David Mulder <dmulder@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

a15208f6

samba-tool: Test gpo show/load handling of utf-16-le strings · a4530c15

David Mulder authored Mar 24, 2022 and

Andrew Bartlett committed Jan 30, 2023



Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

a4530c15

samba-tool: gpo show/load handle utf-16-le strings · 3b0d78a3

David Mulder authored Mar 24, 2022 and

Andrew Bartlett committed Jan 30, 2023



Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

3b0d78a3

samba-tool: gpo load provide option for replace vs merge · e6032703

David Mulder authored Feb 17, 2022 and

Andrew Bartlett committed Jan 30, 2023



Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

e6032703

samba-tool: gpo load set ntacl with SYSVOL file creation · 6f373603

David Mulder authored Feb 16, 2022 and

Andrew Bartlett committed Jan 30, 2023



Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

6f373603

samba-tool: gpo load add Registry ext by default · e7737d6b

David Mulder authored Feb 15, 2022 and

Andrew Bartlett committed Jan 30, 2023



Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

e7737d6b

samba-tool: gpo load extension names · a3452147

David Mulder authored Feb 15, 2022 and

Andrew Bartlett committed Jan 30, 2023



Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

a3452147

samba-tool: gpo load/remove increment GPT.INI · 00e40f9f

David Mulder authored Feb 14, 2022 and

Andrew Bartlett committed Jan 30, 2023



Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

00e40f9f

samba-tool: gpo load/remove bytes · ea619d70

David Mulder authored Jan 24, 2022 and

Andrew Bartlett committed Jan 30, 2023



Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

ea619d70

samba-tool: Test gpo load/remove commands · dc672533

David Mulder authored Jan 21, 2022 and

Andrew Bartlett committed Jan 30, 2023



Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

dc672533

samba-tool: gpo load/remove commands · ee37e3cd

David Mulder authored Jun 29, 2021 and

Andrew Bartlett committed Jan 30, 2023



These commands allow the setting of various group
policies on the sysvol.

Signed-off-by: David Mulder <dmulder@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

ee37e3cd

samba-tool: Move smb_connection to a common file · a0f8d7ca

David Mulder authored Dec 07, 2022 and

Andrew Bartlett committed Jan 30, 2023



This is in preparation for needing it here later.

Signed-off-by: David Mulder <dmulder@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

a0f8d7ca

samba-tool: Move create_directory_hier to a common file · d6194600

David Mulder authored Dec 07, 2022 and

Andrew Bartlett committed Jan 30, 2023



This is in preparation for needing it here later.

Signed-off-by: David Mulder <dmulder@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

d6194600

samba-tool: gpo show command list policies · e40faf7a

David Mulder authored Jun 03, 2021 and

Andrew Bartlett committed Jan 30, 2023



Signed-off-by: David Mulder <dmulder@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Tested-by: Kees van Vloten <keesvanvloten@gmail.com>

e40faf7a

27 Jan, 2023 1 commit

s3:lib: Change file_modtime() to return an error code and a struct timespec. · 7e0eb0f3

Jeremy Allison authored Jan 26, 2023 and

Andreas Schneider committed Jan 27, 2023



Removes need for external stat() code when checking for timechange.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jan 27 08:30:35 UTC 2023 on atb-devel-224

7e0eb0f3

26 Jan, 2023 1 commit

spelling fixes for 4.18 (errror implemenation proces Controler) · 96154a26

Michael Tokarev authored Jan 20, 2023 and

Jeremy Allison committed Jan 26, 2023



One of changes is somewhat interesting, it is "tfork waiter proces"
process title in tfork.c. I wonder why no one noticed this before.
There's another similar process title in there, "tfork waiter process(%d)".
Hopefully no one does grep for "proces$" (and there's no reason to).

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rowland Penny <rpenny@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 26 20:46:11 UTC 2023 on atb-devel-224

96154a26