Commits · christofschmitt-4-8-cluster · The Samba Team / Upstream Samba Development / samba

This project is mirrored from https://gitlab.com/samba-team/samba.git. Pull mirroring updated Apr 21, 2021.

09 Jul, 2018 14 commits

s3: smbtree: use client_messaging_context · ab4d4b56

Christof Schmitt authored Jul 09, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>

ab4d4b56

s3: smbcquotas: use client_messaging_context · 4e4b1880

Christof Schmitt authored Jul 09, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>

4e4b1880

s3: smbcacls: use client_messaging_context · 1e759968

Christof Schmitt authored Jul 09, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>

1e759968

s3: rpcclient: use client_messaging_context · ccf6dcc9

Christof Schmitt authored Jul 09, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>

ccf6dcc9

s3: sharesec: use client_messaging_context · 4cec8f08

Christof Schmitt authored Jul 09, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>

4cec8f08

s3: smbclient: use client_messaging_context · b803be20

Christof Schmitt authored Jul 09, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>

b803be20

s3: smbstatus: use client_messaging_context() · 4793165b

Ralph Böhme authored Jul 09, 2018

Convert one more client to use the client_messaging_context().

smbstatus actually got the messaging setup right, but now that we have
client_messaging_context() let's use it in more places.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>

4793165b

s3: pdbedit: use client_messaging_context() · 49a9cb22

Ralph Böhme authored Jul 09, 2018

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>

49a9cb22

s3: testparm: use client_messaging_context() · 2dc6a0bd

Ralph Böhme authored Jul 05, 2018

This initializes messaging which is needed for registry config and fixes
a crash triggered by running testparm with registry config enabled in
smb.conf, eg by "include = registry".

Registry config calls db_open() and that requires messaging to be up and
running on a cluster.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>

2dc6a0bd

s3: smbpasswd: ensure server_messaging_context() is called before process_options() · 95e96d9b

Ralph Böhme authored Jul 09, 2018

process_options() calls lp_load_global() which, on a cluster with
"include=registry" requires ctdb messaging up an running to do the
db_open() on registry.tdb.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>

95e96d9b

s3: lib/client_contexts: add client event and messaging context · 1bfc8f22

Ralph Böhme authored Jul 09, 2018

This is similar to server_contexts.c, but for clients like smbpasswd,
testparm asf. It streamlines messaging setup which is tricky to get
right on a cluster with include=registry in smb.conf.

client_messaging_context() calls lp_load_initial_only() which is needed
to initialize messaging when checking and creating the directories used
for the messaging sockets and lockfiles.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>

1bfc8f22

s3: lib/server_contexts: make server_event_ctx and server_msg_ctx static · 4aa6833e

Ralph Böhme authored Jul 09, 2018

server_event_ctx and server_msg_ctx static shouldn't be accessible from
outside this compilation unit.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>

4aa6833e

libsmbclient: Initialize written in cli_splice_fallback() · fe25bc79

Bailey Berro authored Jun 26, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13511

Signed-off-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Jul  9 21:29:48 CEST 2018 on sn-devel-144

fe25bc79

libsmbclient: Initialize written value before use. · 2e4878a6

Jeremy Allison authored Jul 06, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13511

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

2e4878a6

07 Jul, 2018 4 commits

winbind_krb5_localauth: Fix a compiler warning · e8b7aecf

Andreas Schneider authored Jul 05, 2018



This can't used uninitialized but some compiler complains about it.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat Jul  7 16:24:30 CEST 2018 on sn-devel-144

e8b7aecf

s3: smbd/durable: remove dev and inode check from vfs_default_durable_reconnect_check_stat() · 0a91ade5

Ralph Böhme authored Mar 02, 2018

On a cluster filesystem the device numbers may differ on the cluster
nodes. We already verify the file_id in vfs_default_durable_reconnect(),
so we can safely remove the dev/inode checks.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13318

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

0a91ade5

lib:charset: Fix error messages from charset conversion · 3430c9c3

Christof Schmitt via samba-technical authored Jun 28, 2018



When e.g. trying to access a filename through Samba that does not adhere
to the encoding configured in 'unix charset', the log will show the
encoding problem, followed by "strstr_m: src malloc fail". The problem
is that strstr_m assumes that any failure from push/pull_ucs2_talloc is
a memory allocation problem, which is not correct.

Address this by removing the misleading messages and add a missing
message in convert_string_talloc_handle.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

3430c9c3

s3: smbd: fix a check in stat_cache_add() · 4ad2a716

Ralph Böhme authored Jun 27, 2018



As the comment above the if condition says:

        /*
         * If we are in case insentive mode, we don't need to
         * store names that need no translation - else, it
         * would be a waste.
         */

Ie if stat_cache_add() is called as

        stat_cache_add("foo/bar", "foo/bar", false)

There's no need to cache the path, as a simple stat() on the client
supplied name (full_orig_name) matches the name used in the
filesystem (passed to stat_cache_add() as translated_path).

So fix the if condition to match the comment.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

4ad2a716

06 Jul, 2018 8 commits

docs/vfs_ceph: add CTDB_SAMBA_SKIP_SHARE_CHECK=yes caveat · 0cd44821

David Disseldorp authored Jul 06, 2018



Mostly copied from the vfs_gluster manpage: the CephFS share path is not
locally mounted, which breaks the ctdb_check_directories_probe() check.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jul  6 23:19:02 CEST 2018 on sn-devel-144

0cd44821

vfs_ceph: don't lie about flock support · 926ae506

David Disseldorp authored Jul 05, 2018

Instead, match vfs_gluster behaviour and require that users explicitly
disable "kernel share modes".

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13506

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

926ae506

s3/loadparm: fix a few talloc stackframe leaks · 887f9147
David Disseldorp authored Jun 25, 2018
```
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
887f9147

s3/service: convert lp_force_user() to const · c58194e3

David Disseldorp authored Jun 25, 2018



Avoid set_conn_force_user_group() talloc stackframe leaks in doing so.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

c58194e3

s3/service: convert lp_force_group() to const · c53646bc

David Disseldorp authored Jun 25, 2018



set_conn_force_user_group() and change_to_user_internal() leak onto
the callers' talloc stackframe. Drop the unnecessary heap allocations.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

c53646bc

s3/uid: use lp_const_servicename() where possible · ce6c77d6

David Disseldorp authored Jun 25, 2018



The majority of these lp_servicename(talloc_tos(), ...) callers leak
onto the talloc stackframe. Drop the unnecessary heap allocations.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

ce6c77d6

s3/service: use lp_const_servicename() where possible · 20a837e8

David Disseldorp authored Jun 25, 2018



The majority of these lp_servicename(talloc_tos(), ...) callers leak
onto the talloc stackframe. Drop the unnecessary heap allocations.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

20a837e8

nsswitch: Use a swtich in the wbinfo test to lookup users · 77be9637

Andreas Schneider authored Jul 06, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13503

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jul  6 17:14:44 CEST 2018 on sn-devel-144

77be9637

05 Jul, 2018 14 commits

ctdb-tests: Avoid segfault by initializing logging · a30ac853

Amitay Isaacs authored Jul 05, 2018

This is in addition to af697008

.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Jul  5 15:22:16 CEST 2018 on sn-devel-144

a30ac853

ctdb-common: Fix CID 437606 · b2d75c01

Amitay Isaacs authored Jul 04, 2018


Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

b2d75c01

selftest: Use a longer self.account_lockout_duration and self.lockout_observation_window · f0336457

Andrew Bartlett authored Jul 03, 2018

This matches the changes made in the PSO tests and slows down the
whole testsuite but may make it more reliable on slower build hosts.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Jul 5 12:29:31 CEST 2018 on sn-devel-144

f0336457

selftest: Use self.account_lockout_duration in self.update_lockout_settings... · 9ff1fa56

Andrew Bartlett authored Jul 03, 2018


selftest: Use self.account_lockout_duration in self.update_lockout_settings for password_lockout tests

This allows the account_lockout_duration and
lockout_observation_window to be updated with longer values to cope
with slower build servers.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

9ff1fa56

Document that vfs_full_audit defaults are "none" for the successful and failed operations. · 9f38df83

Timur I. Bakeyev authored Jun 22, 2018


Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

9f38df83

Make "none" the default setting for the successful and failed operations in... · d63b24d5

Timur I. Bakeyev authored Jun 22, 2018

Make "none" the default setting for the successful and failed operations in the vfs_full_audit, so you don't blow up your server by just adding this module to the configuration.
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

d63b24d5

Make sure that vfs*audit modules recognize and accept all the syslog facilities. · 32e5b18d

Timur I. Bakeyev authored Jul 02, 2018

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13436

Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

32e5b18d

ctdb-tests: Switch to using new event daemon · dda99e49

Amitay Isaacs authored Jun 21, 2018


Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Jul  5 09:39:33 CEST 2018 on sn-devel-144

dda99e49

ctdb-daemon: Add client code to talk to new event daemon · db548f48

Amitay Isaacs authored Jun 21, 2018



This fixes the build and now new eventd is integrated completely in CTDB.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

db548f48

ctdb-protocol: Remove protocol for old event daemon · 8250072a

Amitay Isaacs authored Jun 21, 2018



This breaks the build.  The new eventd protocol cannot be introduced without
removing the old eventd protocol.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

8250072a

ctdb-client: Remove client code for old event daemon · 0e444c96
Amitay Isaacs authored Jun 21, 2018
```
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
```
0e444c96

ctdb-tools: Remove old event daemon tool · b6938c09

Amitay Isaacs authored Jun 21, 2018


Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

b6938c09

ctdb-daemon: Remove old event daemon · ce3db0d4

Amitay Isaacs authored Jun 21, 2018


Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

ce3db0d4

ctdb-tests: Remove tests for old event daemon · 99fa3a34

Amitay Isaacs authored Jun 21, 2018


Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

99fa3a34